Loosen scaled data accuracy to 10mV in AO test cases #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhindes
approved these changes
Jul 3, 2024
|
We talked about this offline. These tests generate signals 1V apart. The data validation is only intended to detect gross SW-problems, like channel swapping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR fixes AO tests occasionally fail on real HW by loosening scaled data accuracy to 10mV.
Why should this Pull Request be merged?
This is to address a bug filed internally for failing AO tests occasionally.
What testing has been done?
Tested on PXIe-6363, pass.